Fix collection issue in Pytest 9 with overridden fixtures#376
Fix collection issue in Pytest 9 with overridden fixtures#376smarie merged 6 commits intosmarie:mainfrom
Conversation
|
|
||
| # add all dependencies in the to do list | ||
| dependencies = _fixdef.argnames | ||
| # add all dependencies, accounting for overrides |
There was a problem hiding this comment.
I wasn't able to make a test case that would affect the equivalent on line 322 so I didn't make any changes there
|
This is awesome @jammer87 ! I'll take some time to review all of these and come back with either comments or merge |
|
Hello @jammer87 , thanks for your patience ! I was able to
However there are more complex situations that are not handled in this fix and that were further handled by pytest-dev/pytest#13789. I am looking at them now to make sure the fix covers all |
…ytest. It has not been tested against pytest<9
|
Since I found an issue in pytest while updating your PR to handle all situations, I propose that we rather merge it as is. I pushed a changelog and a fix for the CI to be able to run again. |
|
All set, thanks @jammer87 for this difficult fix ! |
2 participants
Addresses #374 which was introduced by the pytest fixes for pytest-dev/pytest#13773
@smarie feel free to close/take over as part of larger Pytest 9 support.
If you want a single PR with #376, #377, #378, #379, #380 with merge conflicts fixed, you can create a new one from https://github.com/jammer87/python-pytest-cases/tree/all-my-merges